From fcf49fa1232d4745388a6634bc34f5dd64d3fb0b Mon Sep 17 00:00:00 2001 From: Sonny Date: Mon, 29 Jun 2020 20:54:46 +0200 Subject: [PATCH] Update logging calls --- src/newsreader/news/collection/feed.py | 6 ++++-- src/newsreader/news/collection/tasks.py | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/newsreader/news/collection/feed.py b/src/newsreader/news/collection/feed.py index 35b0b1e..e237713 100644 --- a/src/newsreader/news/collection/feed.py +++ b/src/newsreader/news/collection/feed.py @@ -162,6 +162,8 @@ class FeedClient(Client): yield response_data except StreamException as e: + logger.exception("Request failed") + length = stream.rule._meta.get_field("error").max_length stream.rule.error = e.message[-length:] stream.rule.succeeded = False @@ -277,7 +279,7 @@ class FeedDuplicateHandler: remote_identifier=instance.remote_identifier ) except ObjectDoesNotExist: - logger.error( + logger.exception( f"Duplicate handler tried retrieving post {instance.remote_identifier} but failed doing so." ) return instance @@ -300,7 +302,7 @@ class FeedDuplicateHandler: try: existing_post = self.queryset.get(**query_values) except ObjectDoesNotExist: - logger.error( + logger.exception( f"Duplicate handler tried retrieving post {instance.remote_identifier} but failed doing so." ) return instance diff --git a/src/newsreader/news/collection/tasks.py b/src/newsreader/news/collection/tasks.py index 6888cba..c02953e 100644 --- a/src/newsreader/news/collection/tasks.py +++ b/src/newsreader/news/collection/tasks.py @@ -34,7 +34,9 @@ class FeedTask(app.Task): collector = FeedCollector() collector.collect(rules=rules) else: - logger.info(f"Cancelling task due to existing lock for user {user_pk}") + logger.warning( + f"Cancelling task due to existing lock for user {user_pk}" + ) raise Reject(reason="Task already running", requeue=False)